New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localProxyHost requires an additional dash #61

Open

mattonem wants to merge 1 commit into browserstack:master from mattonem:patch-1

mattonem commented Nov 10, 2021

We add some syntactic sugar for proxyHost, Local will automatically add a dash a that beginning of the parameter name.
see link:

browserstack-local-java/src/main/java/com/browserstack/local/Local.java

Line 42 in 3ffdab3

parameters.put("proxyHost", "-proxyHost");

But don't have the same behavior with localProxyHost. So we must use -localProxyHost instead.

Same for localProxyPort


          localProxyHost requires an additional dash

We add some syntactic sugar for `proxyHost`, Local will automatically add a dash a that beginning of the parameter name. 
see link: https://github.com/browserstack/browserstack-local-java/blob/3ffdab3366fa24e6d0809da5093b200cf7be8794/src/main/java/com/browserstack/local/Local.java#L42
But don't have the same behavior with localProxyHost. So we must use `-localProxyHost` instead.

Same for localProxyPort

zigasternad commented Jan 15, 2025

+1

Why is this PR not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet