Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): refactor example instructions #175

Conversation

vados-cosmonic
Copy link
Contributor

This PR refactors the example and makes it a little easier to follow, separating the Rust and JS components and updating the test script.

@vados-cosmonic vados-cosmonic force-pushed the refactor(examples)=rework-example-instructions branch 2 times, most recently from ba7204d to 91f616a Compare December 31, 2024 04:49
@leoyvens
Copy link

leoyvens commented Jan 3, 2025

Should the API section of the README also be updated? It doesn't seem to reflect the current API.

@vados-cosmonic
Copy link
Contributor Author

Hey @leoyvens I think you're right -- would welcome a PR (+/- issue!) to update the main README! I'm not sure that page has seen a change in a while.

@vados-cosmonic vados-cosmonic force-pushed the refactor(examples)=rework-example-instructions branch 3 times, most recently from c756e70 to 13e693e Compare January 8, 2025 17:05
@guybedford
Copy link
Collaborator

Just let me know when this one is ready for review and it would be great to take a look further.

@vados-cosmonic vados-cosmonic force-pushed the refactor(examples)=rework-example-instructions branch from 13e693e to 003f152 Compare January 8, 2025 17:28
@vados-cosmonic vados-cosmonic force-pushed the refactor(examples)=rework-example-instructions branch from 003f152 to 51e8ba5 Compare January 8, 2025 17:48
@vados-cosmonic
Copy link
Contributor Author

Sorry, the CI to run the updated test.sh script still wasn't right -- GH actions changes + typos that snuck in. The refactor itself doesn't change the projects themselves dramatically, but the script to orchestrate the tests did change a bit.

Should be good to go -- CI is 🟢 except for the AOT performance check that has been failing for a while now on main (which is unrelated):


  1) Builtins
       performance:
     Error: took more than half a millisecond - 3.469573974609375 ms
      at test (file:///home/runner/work/ComponentizeJS/ComponentizeJS/test/builtins/performance.js:26:11)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async Context.<anonymous> (file:///home/runner/work/ComponentizeJS/ComponentizeJS/test/test.js:76:9)

@guybedford guybedford merged commit d8dd995 into bytecodealliance:main Jan 8, 2025
10 of 11 checks passed
@guybedford
Copy link
Collaborator

This is great, thanks for the PR.

@vados-cosmonic vados-cosmonic deleted the refactor(examples)=rework-example-instructions branch January 9, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants