Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation_on_android.yml: Add shared lib build #3975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

midokura-xavi92
Copy link
Contributor

So far, no workflows would attempt to build the shared version of the iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS, the actual default options defined by the build system are assumed, for the sake of simplicity and avoiding repeated code.

@lum1n0us
Copy link
Collaborator

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

@midokura-xavi92
Copy link
Contributor Author

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

I do not decide which artifacts should be built for release, so I assume the latter only for now. I will then update the PR to only modify _.github/workflows/compilation_on__*.

@lum1n0us
Copy link
Collaborator

lum1n0us commented Jan 9, 2025

@midokura-xavi92 I noticed that the PR has been inactive for a few weeks. It looks like it’s almost ready to be merged, and it would be great to see it completed. Would you be able to make the necessary modifications? If you need any help or have any questions, please feel free to reach out. Your contribution is highly appreciated!

@midokura-xavi92
Copy link
Contributor Author

@lum1n0us I have just updated the branch so as to modify .github/workflows/compilation_on_android_ubuntu.yml. If you agree with the proposal, I can extend it to .github/workflows/compilation_on_sgx.yml or any other workflows you might prefer.

@midokura-xavi92 midokura-xavi92 changed the title build_iwasm_release.yml: Add shared lib build compilation_on_android.yml: Add shared lib build Jan 9, 2025
@@ -136,6 +137,7 @@ jobs:
$LLVM_LAZY_JIT_BUILD_OPTIONS,
$LLVM_EAGER_JIT_BUILD_OPTIONS,
$MULTI_TIER_JIT_BUILD_OPTIONS,
$SHARED_BUILD_OPTIONS,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here. this is for variant running mode only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add SHARED_BUILD_OPTIONS into make_options_feature. It will test SHARED_BUILD_OPTIONS with all kinds of running mode

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change made at line 139 should be undone. That section is intended solely for the run mode configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -189,6 +191,8 @@ jobs:
make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1"
- make_options_run_mode: $MULTI_TIER_JIT_BUILD_OPTIONS
make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1"
- make_options_run_mode: $SHARED_BUILD_OPTIONS
make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here neither. this usually mean some features are not supported by special running mode

@midokura-xavi92
Copy link
Contributor Author

Thanks for the tips, @lum1n0us . Please let me know whether the changes are valid now.

@@ -175,6 +176,8 @@ jobs:
make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1"
- make_options_run_mode: $MULTI_TIER_JIT_BUILD_OPTIONS
make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1"
- make_options_run_mode: $SHARED_BUILD_OPTIONS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar with .github/workflows/compilation_on_android_ubuntu.yml

@@ -35,6 +35,7 @@ env:
LLVM_LAZY_JIT_BUILD_OPTIONS: " -DWAMR_BUILD_AOT=1 -DWAMR_BUILD_FAST_INTERP=0 -DWAMR_BUILD_INTERP=0 -DWAMR_BUILD_FAST_JIT=0 -DWAMR_BUILD_JIT=1 -DWAMR_BUILD_LAZY_JIT=1"
LLVM_EAGER_JIT_BUILD_OPTIONS: "-DWAMR_BUILD_AOT=1 -DWAMR_BUILD_FAST_INTERP=0 -DWAMR_BUILD_INTERP=0 -DWAMR_BUILD_FAST_JIT=0 -DWAMR_BUILD_JIT=1 -DWAMR_BUILD_LAZY_JIT=0"
MULTI_TIER_JIT_BUILD_OPTIONS: "-DWAMR_BUILD_AOT=1 -DWAMR_BUILD_FAST_INTERP=0 -DWAMR_BUILD_INTERP=1 -DWAMR_BUILD_FAST_JIT=1 -DWAMR_BUILD_JIT=1 -DWAMR_BUILD_LAZY_JIT=1"
SHARED_BUILD_OPTIONS: " -DWAMR_BUILD_STATIC=0 -DWAMR_BUILD_SHARED=1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar with .github/workflows/compilation_on_android_ubuntu.yml

So far, no workflows would attempt to build the shared version of the
iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS,
the actual default options defined by the build system are assumed, for
the sake of simplicity and avoiding repeated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants