pulley: Fix a panic in using a return pointer #9967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a panic in the pulley backend introduced in bytecodealliance#9874 which comes up when using a return pointer on call instructions. This would shuffle the `uses` list of registers to not be sorted like the assertion was expecting. The fix in this commit is to just go ahead and sort the list of `uses` to ensure that registers are peeled off in order.
alexcrichton
requested review from
abrown and
fitzgen
and removed request for
a team
github-actions
bot
added
the
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic in the pulley backend introduced in #9874 which comes up when using a return pointer on call instructions. This would shuffle the
useslist of registers to not be sorted like the assertion was expecting. The fix in this commit is to just go ahead and sort the list ofusesto ensure that registers are peeled off in order.