Apply suggestions from code review

Co-authored-by: yowl <[email protected]> Co-authored-by: Joel Dice <[email protected]>
bytecodealliance · Jan 9, 2025 · 4dab24c · 4dab24c
1 parent d77a265
commit 4dab24c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/crates/csharp/src/function.rs b/crates/csharp/src/function.rs
@@ -241,7 +241,8 @@ impl<'a, 'b> FunctionBindgen<'a, 'b> {
                 uwrite!(
                     self.src,
                     "\
-                                        if ({previous}.IsOk) {{
+                                        if ({previous}.IsOk) 
+                                        {{
                                         var {tmp} = {previous}.AsOk;
                                     "
                 );
@@ -272,7 +273,9 @@ impl<'a, 'b> FunctionBindgen<'a, 'b> {
             uwrite!(
                 self.src,
                 "\
-                                    }} else {{
+                                    }} 
+                                    else 
+                                    {{
                                         throw new {exception_name}({var_name}.AsErr!, {level});
                                     }}
                                     "
@@ -317,7 +320,8 @@ impl<'a, 'b> FunctionBindgen<'a, 'b> {
             let tail = oks.iter().map(|_| ")").collect::<Vec<_>>().concat();
             cases.push(format!(
                 "\
-                                            case {index}: {{
+                                            case {index}: 
+                                            {{
                                                 ret = {head}{ty}.Err(({err_ty}) e.Value){tail};
                                                 break;
                                             }}
@@ -327,7 +331,9 @@ impl<'a, 'b> FunctionBindgen<'a, 'b> {
             payload_is_void = result.ok.is_none();
         }
         if !self.results.is_empty() {
-            self.src.push_str("try {\n");
+            self.src.push_str(\"
+                               try 
+                               {\n");
         }
         let head = oks.concat();
         let tail = oks.iter().map(|_| ")").collect::<Vec<_>>().concat();
@@ -343,8 +349,11 @@ impl<'a, 'b> FunctionBindgen<'a, 'b> {
             let cases = cases.join("\n");
             uwriteln!(
                 self.src,
-                r#"}} catch (WitException e) {{
-                                            switch (e.NestingLevel) {{
+                r#"}} 
+                   catch (WitException e) 
+                   {{
+                                            switch (e.NestingLevel) 
+                                            {{
                                                 {cases}
 
                                                 default: throw new ArgumentException($"invalid nesting level: {{e.NestingLevel}}");

diff --git a/crates/csharp/src/lib.rs b/crates/csharp/src/lib.rs
@@ -31,7 +31,7 @@ pub struct Opts {
     #[cfg_attr(feature = "clap", arg(long))]
     pub skip_support_files: bool,
 
-    /// Generates code for wit Result types instead of exceptions
+    /// Generate code for WIT `Result` types instead of exceptions
     #[cfg_attr(feature = "clap", arg(long))]
     pub with_wit_results: bool,
 }

diff --git a/tests/runtime/results/wasm_with_wit_results.cs b/tests/runtime/results/wasm_with_wit_results.cs
@@ -12,7 +12,7 @@ public static Result<float, string> StringError(float a)
             var result = imports.test.results.TestInterop.EnumError(a);
             if (result.IsOk) {
                 return Result<float, ITest.E>.Ok(result.AsOk);
-            }else{
+            } else {
                 switch (result.AsErr){
                     case imports.test.results.ITest.E.A:
                         return Result<float, ITest.E>.Err(ITest.E.A);