Initial dependency upgrades and associated fixes #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For: * About * AccessibilityStatement * App * Appendix * Demo * Faq * FillForms * Manual * OeciLogin * PartnerInterest * PrivacyPolicy * RecordSearch * Rules - Update package.json * Change node-sass dependency to sass * Upgrade prettier to match project root .pre-commit-config.yaml
* Remove unused imports * About: remove unnecessary "Photo of" * App: replace kabob-case attributes * DemoInfo: add missing keys * Landing: don't nest within <p> * PartnerTable: at missing keys, use === instead of ==, replace kabob-case attributes * Record/Case: add `rel="noopener noreferrer" * Rules/ChargeTypeRule: use === instead of == * reducer: use forEach instead of map, replace reduce comma shorthand function returns * Add missing types for promise resolve parameter and action functions * selectors test: add missing mockData attributes
for: * ChargestList * util.newlineOrsInString()
KentShikama
approved these changes
Jan 16, 2023
| @@ -148,7 +148,7 @@ export default class About extends React.Component { | |||
| <img | |||
| className="img w5 mb3" | |||
| src="/img/ks-2x.jpg" | |||
| alt="Photo of Kent Shikama" | |||
| alt="Kent Shikama" | |||
| /> | |||
| <dl> | |||
| <dt className="fw8 mb2">Kent Shikama</dt> | |||
There was a problem hiding this comment.
Feel free to add your name btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KentShikama, this is the beginning of #1634. The first batch is focused on getting to a baseline before future changes.
Commit 1
.pre-commit-config.yaml. We could upgrade that in a future commit, if you think it would be okay.Commits 2 and 3
Commit 4
There were some problems with using newer versions of TS and react-scripts with the older node version we had. Upgrading to
node:18.13-bullseyefixed those.With these commits, the frontend dev environment should be generally good to go. However, on my Macbook, I've been having problems with the
docker-compose.ymlbinding to port 5000. I've been using"5001:5000"port binding instead. If you don't think that port binding would cause other problems (I'm still having problems getting the backend container to work), then I could add that change to this PR. Please let me know.Thanks.