Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot and bump up golang and dependency versions #178

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add dependabot and bump up golang and dependency versions #178

merged 2 commits into from
Jan 14, 2025

Conversation

djdongjin
Copy link
Member

@djdongjin djdongjin commented Dec 28, 2024 •
edited
Loading

This PR:

  1. Add dependabot CI. This repo used to have dependabot PRs (Bump golang.org/x/net from 0.17.0 to 0.23.0 #167) but somehow it stopped and there is no dependabot config.
  2. Upgrade go, dependencies, CI versions (to the same versions as containerd)

@djdongjin
Add dependabot CI
644ecfa 
Signed-off-by: Jin Dong <[email protected]>
@djdongjin djdongjin force-pushed the bump-versions branch 5 times, most recently from 9e2ab03 to 4d4cdca Compare December 28, 2024 03:16
@djdongjin djdongjin changed the title Bump up golang and dependency versions Add dependabot and bump up golang and dependency versions Dec 28, 2024
@djdongjin djdongjin mentioned this pull request Dec 29, 2024
Merged
fuweid
fuweid reviewed Dec 30, 2024
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@djdongjin djdongjin requested a review from fuweid December 30, 2024 01:51
djdongjin
djdongjin commented Dec 30, 2024
View reviewed changes
go.mod
@@ -1,19 +1,16 @@
module github.com/containerd/ttrpc

go 1.19
go 1.22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly to keep the dependencies up-to-date.

e.g., for google.golang.org/grpc
v1.69.2 requires 1.22
v1.67.3 requires 1.21

Let me know if there is any concern.

kzys
kzys approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Go 1.22 is the oldest supported Go version.

@kzys kzys merged commit ababa3f into containerd:main Jan 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@kzys kzys kzys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djdongjin @kzys @fuweid