Do not load complete product again from database on pre_update #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@BlackbitDevs the SQL inside the listener is fine, but can you Dependency Inject the SQL Connection and not use \Pimcore\DB ? |
|
ping @BlackbitDevs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a product gets saved, currently during
pimcore.dataobject.preUpdateevent the whole object gets loaded again from database - only to find out if thepublishedstate got changed. This is quite expensive from performance perspective. This PR changes this with a direct SQL query. I am quite sure that you will not accept it because of the SQL inside an event listener but maybe we can find a clean solution...