Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise Python to language agnostic errors #184

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Jan 13, 2025

🤔 What's changed?

  • Consolidate Python error messages to standardised format

<TBD>

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

  • At present, it appears this will affect some unit tests within behave matching these error messages - with behave pinning cucumber-tag-expressions >= 4.1.0
  • Whether consider any regressions within error messages
  • Whether appropriate to align these errors with other implementations - given the reason listed against the error messages: "TOO MANY DIFFERENCES: Error message here are more specific (IMHO)"
  • Guidance/direction - what is appropriate way to resolve - interested in all perspectives
  • Points of extension within Behave - for awareness

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan added the 🏦 debt Tech debt label Jan 13, 2025
@kieran-ryan
Copy link
Member Author

kieran-ryan commented Jan 13, 2025

Pending small optimisations following redactions, some further exploratory testing, cleaning up the PR description; properly evaluating compatibility with points of extension by Behave; and ultimately agreement on whether aligning with this format is something we should proceed with (particularly if any error messages considered a regression) or whether we should look to enhance messages (or even a subset) alongside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Make tests pass against shared test data
1 participant