-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove refresh option #2350
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only issue could be some old old extension clients, but not worried about it.
""" | ||
Force refresh the feed | ||
""" | ||
refresh: Boolean = false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebelchris just to double check that frontend does not send this in any way 🙏 (if you did not already)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only removing it in the next app release here:
dailydotdev/apps#3687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And extension, does it request it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the feeds do request it, so we can wait for adoption first to be safe I guess :)
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have much to add 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this yet, going to use it during engineering meeting tomorrow, so putting a blocker on it
@rebelchris time to merge this? 🙈 |
@omBratteng Think adoption is still low, considering also we have all the firefox users who can't update 😢 |
:lolsob: |
Maybe now? 👀 |
…move-refresh # Conflicts: # src/schema/feeds.ts
@capJavert The biggest issue is still the Firefox extension that never got updated. |
@rebelchris no, let's leave it, its not a drastic thing. |
We actually no longer use this.