Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refresh option #2350

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: remove refresh option #2350

wants to merge 4 commits into from

Conversation

rebelchris
Copy link
Contributor

We actually no longer use this.

@rebelchris rebelchris marked this pull request as ready for review October 17, 2024 10:25
@rebelchris rebelchris requested review from capJavert and a team as code owners October 17, 2024 10:25
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue could be some old old extension clients, but not worried about it.

Comment on lines -314 to -385
"""
Force refresh the feed
"""
refresh: Boolean = false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebelchris just to double check that frontend does not send this in any way 🙏 (if you did not already)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only removing it in the next app release here:
dailydotdev/apps#3687

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And extension, does it request it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the feeds do request it, so we can wait for adoption first to be safe I guess :)

This comment was marked as spam.

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much to add 🚀

Copy link
Member

@omBratteng omBratteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this yet, going to use it during engineering meeting tomorrow, so putting a blocker on it

@omBratteng
Copy link
Member

@rebelchris time to merge this? 🙈

@rebelchris
Copy link
Contributor Author

@omBratteng Think adoption is still low, considering also we have all the firefox users who can't update 😢

@omBratteng
Copy link
Member

:lolsob:

@capJavert
Copy link
Contributor

Maybe now? 👀

…move-refresh

# Conflicts:
#	src/schema/feeds.ts
@rebelchris
Copy link
Contributor Author

@capJavert The biggest issue is still the Firefox extension that never got updated.
I'm ok with deploying though?

@capJavert
Copy link
Contributor

@rebelchris no, let's leave it, its not a drastic thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants