Some Trickle ICE related issues #4
Conversation
Replace simple-peer ready event with connect event
Fingerupdate was triggered multiple times, as connect event was attached for each signalling message (offer, answer, candidates), still related to trickle ICE support
|
Hi @areiter , thank you for showing up and contributing. Could you explain me a bit more about "removing bows because it is not compatible with node"? webrtc-explorer was built to run on the browser. |
| self.events.emit('registered', {peerId: data.peerId}); | ||
| } | ||
|
|
||
| ioc.emit('s-register', {}); | ||
| ioc.emit('s-register', {'id' : peerId}); |
There was a problem hiding this comment.
right now, the Signalling Server pick the ID's, are you proposing to change that?
There was a problem hiding this comment.
I have some modified requirements on the framework, one among is providing a way to give the signalling server a hint which id the client wants to have.
I think that's just one of the changes you should ignore ;-)
Maybe I should have made a seperate repository with these changes, sorry for that
|
I see that your goal is to have WebRTC explorer working both in the browser and in Node.js? That's pretty cool. Have you looked at the Signalling Server? It is the rendezvous point for WebRTC peers to connect between themselves - https://github.com/diasdavid/webrtc-explorer-signalling-server |
|
I'm aware of the signalling server as an integral part of the system. From my point-of-view, an ideal solution would be to have a single module, running in the browser and in the node environment. |
I agree, and if we can work together on that, I'm all aboard. Nevertheless, I should inform you, that if you are looking for DHT for Node.js only, you probably don't want to use webrtc-explorer or webrtc at all, you could avoid all of the signalling stuff or even having to have several Data Channels open, since dealing a socket is way cheaper. |
|
I opened a issue of where to go next - #5 |
|
Browser <--> Node interoperability would be really nice :-) |
…t callback to signalling server events
…s among the nodes
… connection from peer
Commit a5a3a78 removes bows and updates , as it's not compatible with node, everything else seems also to work with nodejs.
Sorry, there are also some other nodejs related changes incorporated.