Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): add FileHandle#writeFile #25555

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(ext/node): add FileHandle#writeFile #25555

merged 2 commits into from
Sep 11, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 10, 2024

This PR adds writeFile methods of FileHandle class https://nodejs.org/api/fs.html#filehandlewritefiledata-options

closes #25528

part of #25554

@kt3k kt3k changed the title fix(ext/node): add FileHandle#writeFile fix(ext/node): add FileHandle#writeFile Sep 10, 2024
nathanwhit
nathanwhit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 8bdd364 into denoland:main Sep 11, 2024
17 checks passed
@kt3k kt3k deleted the fix-node-fs-file-handle-write-file branch September 11, 2024 10:17
@kt3k kt3k mentioned this pull request Sep 10, 2024
Open
24 tasks
@kt3k kt3k mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno fails to run puppeteer
3 participants
@kt3k @nathanwhit @lucacasonato