fix(node/fs): add sync method to filehandle method #27089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #25554 |
kt3k
reviewed
Nov 26, 2024
| @@ -189,6 +189,7 @@ const promises = { | |||
| appendFile: appendFilePromise, | |||
| readFile: readFilePromise, | |||
| watch: watchPromise, | |||
| sync: fsyncSync, | |||
There was a problem hiding this comment.
promises.sync doesn't seem existing in Node.js fs docs https://nodejs.org/api/fs.html
Or am I missing something?
There was a problem hiding this comment.
Oh, this is my problem. Do I need to delete it now？
Thank you for your reply
There was a problem hiding this comment.
ok, I'm done. Thank you for your reply
There was a problem hiding this comment.
Thanks for taking a look! Maybe a commit wasn't pushed correctly. This line here is still included in the changes of the PR.
There was a problem hiding this comment.
here be61bce (#27089)
Is this correct ？
thank you for your replay
dsherret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
links #25554