Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compiler options from workspace member #143

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Nov 26, 2024

src/workspace/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's update https://github.com/denoland/deno/pull/27009/files with this before merging.

@nayeemrmn
Copy link
Collaborator Author

Looks good, but let's update https://github.com/denoland/deno/pull/27009/files with this before merging.

It's blocked by the other updates carried out in denoland/deno#27096.

@nayeemrmn
Copy link
Collaborator Author

Actually I'll patch it on top of 0.39.2 and try it with that for now: https://github.com/denoland/deno_config/tree/0-39-2-compiler-options-from-workspace-member.

@nayeemrmn nayeemrmn requested a review from dsherret November 27, 2024 21:52
@nayeemrmn nayeemrmn force-pushed the compiler-options-from-workspace-member branch from 2480a67 to 4115bab Compare December 7, 2024 00:33
@nayeemrmn nayeemrmn force-pushed the compiler-options-from-workspace-member branch from 4115bab to 8e4caf2 Compare December 7, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants