example: add more examples #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
littledivy
requested changes
Jan 4, 2025
examples/monoio_tlsclient.rs
Outdated
| } | ||
| } | ||
|
|
||
| unsafe impl Send for HyperConnection {} |
There was a problem hiding this comment.
Can you add a safety comment here as to why this is safe?
examples/monoio_tlsclient.rs
Outdated
| } | ||
|
|
||
| use std::pin::Pin; | ||
| // struct HyperConnection(monoio::net::tcp::stream_poll::TcpStreamPoll); |
There was a problem hiding this comment.
Suggested change
| // struct HyperConnection(monoio::net::tcp::stream_poll::TcpStreamPoll); |
examples/monoio_tlsclient.rs
Outdated
Comment on lines
104
to
105
| // !!!!! do not use proxychains or other proxy tools, the tcp steam connect may be failed !!!! | ||
| let uri: Uri = "data-stream.binance.com".parse::<hyper::Uri>().unwrap(); |
There was a problem hiding this comment.
I think we should connect to a local echo server instead of a remote service like binance.
|
this is decided by monoio runtime features, and the safe reason can checkout bytedance/monoio#218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.