Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to axum 0.8 #97

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

sebadob
Copy link
Contributor

@sebadob sebadob commented Jan 14, 2025

Makes the crate usable with axum-0.8. This does not handle any HTTP/2 stuff though.

@sebadob
Copy link
Contributor Author

sebadob commented Jan 14, 2025

btw is there a specific reason why the Cargo.lock has been checked into version control?

@sebadob sebadob changed the title fix: upgrade axum 0 8 fix: upgrade to axum 0.8 Jan 14, 2025
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Lockfiles are meant to be checked-in version control to ensure everyone is using the exact same version of every library.

@littledivy littledivy merged commit 9101613 into denoland:main Jan 14, 2025
3 checks passed
@littledivy
Copy link
Member

Released 0.10.0

@sebadob
Copy link
Contributor Author

sebadob commented Jan 14, 2025

Lockfiles are meant to be checked-in version control to ensure everyone is using the exact same version of every library.

Yes of course, but you usually don't do it for crates that are no standalone binaries to avoid possible annoying conflicts and let cargo handle it via semantic versioning, that's why I was asking.

Released 0.10.0

Thanks a lot! That was a quick one and immediately resolved my blocker. :)

MokerWill pushed a commit to MokerWill/fastwebsockets that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants