fix(data-structures): implement deep cloning for BinarySearchNode and… #6316
+104
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update BinarySearchTree.from() to ensure independent copies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.01%
==========================================
Files 547 547
Lines 41671 41665 -6
Branches 6314 6309 -5
==========================================
- Hits 40147 40141 -6
Misses 1482 1482
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… update BinarySearchTree.from() to ensure independent copies
Although this change fixes the tree replication issue, it also changes the original behavior of nodes. If a user implements other trees (such as AVL trees) based on this node. Then it may cause other problems. So this merge is only a reference and may not be merged