Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add readDir #6338

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

jbronder
Copy link
Contributor

@jbronder jbronder commented Jan 8, 2025

This PR adds the readDir API to @std/fs, which is a function intended to mirror Deno.readDir.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner January 8, 2025 04:22
@github-actions github-actions bot added the fs label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 96.40%. Comparing base (3c1b8e9) to head (aa613c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_read_dir.ts 50.00% 10 Missing ⚠️
fs/_to_dir_entry.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6338      +/-   ##
==========================================
- Coverage   96.44%   96.40%   -0.04%     
==========================================
  Files         547      549       +2     
  Lines       41812    41841      +29     
  Branches     6348     6350       +2     
==========================================
+ Hits        40325    40337      +12     
- Misses       1447     1464      +17     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@kt3k kt3k merged commit 55b1c7e into denoland:main Jan 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants