Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: better release workflow #10325

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jun 5, 2024

Please describe the changes this PR makes and why it should be merged:

Creates a proper release workflow, works in ci as well as locally.

This

  • determines the release tree
  • releases all packages in scope, or all packages necessary to release the specified package
  • if a package is already released at a version, the registry check will allow it to skip publishing that package
  •  sanity checks publish completion before moving to the next branch of the release tree
  • creates the tag and publishes a release on github

Status and versioning classification:

@ckohen ckohen requested review from a team and iCrawl as code owners June 5, 2024 12:47
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 1:31am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 1:31am

@ckohen ckohen requested review from Jiralite and almeidx June 6, 2024 08:01
@ckohen ckohen force-pushed the ci/better-release branch 2 times, most recently from 8880b32 to 536eeef Compare June 8, 2024 01:16
@ckohen ckohen requested a review from Jiralite June 8, 2024 01:21
kyranet
kyranet previously requested changes Jun 9, 2024
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, pressed the wrong button 😅

@ckohen ckohen requested a review from kyranet June 9, 2024 16:45
@ckohen ckohen requested a review from vladfrangu June 12, 2024 08:48
@ckohen ckohen force-pushed the ci/better-release branch from 970c52e to d526ed9 Compare June 19, 2024 13:06
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes missing coverage. Please review.

Project coverage is 34.91%. Comparing base (4374374) to head (696a65e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...actions/src/releasePackages/generateReleaseTree.ts 0.00% 156 Missing ⚠️
...ages/actions/src/releasePackages/releasePackage.ts 0.00% 66 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10325      +/-   ##
==========================================
- Coverage   35.45%   34.91%   -0.55%     
==========================================
  Files         228      230       +2     
  Lines       14319    14541     +222     
  Branches     1254     1256       +2     
==========================================
  Hits         5077     5077              
- Misses       9198     9420     +222     
  Partials       44       44              
Flag Coverage Δ
brokers 31.44% <ø> (ø)
builders 91.58% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 97.43% <ø> (ø)
guide 0.54% <ø> (ø)
proxy 66.27% <ø> (ø)
rest 87.37% <ø> (ø)
util 41.42% <ø> (ø)
utilities 6.32% <0.00%> (-93.68%) ⬇️
voice 63.64% <ø> (ø)
website 0.00% <ø> (ø)
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckohen ckohen requested a review from vladfrangu June 19, 2024 13:39
@ckohen ckohen force-pushed the ci/better-release branch from da71777 to 637266d Compare June 21, 2024 12:37
.github/workflows/publish-dev.yml Outdated Show resolved Hide resolved
@ckohen ckohen force-pushed the ci/better-release branch 2 times, most recently from d6bac5a to 831d334 Compare August 24, 2024 19:11
Copy link

vercel bot commented Aug 24, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@ckohen ckohen force-pushed the ci/better-release branch from 831d334 to 4952578 Compare August 24, 2024 20:56
@ckohen ckohen force-pushed the ci/better-release branch from 4952578 to c9686b4 Compare August 28, 2024 23:27
@Jiralite Jiralite removed the request for review from suneettipirneni January 11, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

6 participants