refactor!: consolidate parameters into a single options object
#10718
+48
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sdanialraza
force-pushed
the
refactor/consolidate-parameters-single-options-object
branch
3 times, most recently
from
9823d14 to
f948dab
Compare
vladfrangu
approved these changes
Jan 21, 2025
Jiralite
reviewed
Jan 21, 2025
sdanialraza
force-pushed
the
refactor/consolidate-parameters-single-options-object
branch
from
6effd93 to
3dd35b1
Compare
didinele
approved these changes
Jan 24, 2025
Jiralite
requested changes
Jan 24, 2025
Done |
Jiralite
approved these changes
Jan 24, 2025
almeidx
previously requested changes
Jan 24, 2025
sdanialraza
force-pushed
the
refactor/consolidate-parameters-single-options-object
branch
from
162f21e to
59b7252
Compare
almeidx
requested changes
Jan 25, 2025
Co-authored-by: Almeida <[email protected]>
almeidx
approved these changes
Jan 25, 2025
sdanialraza
deleted the
refactor/consolidate-parameters-single-options-object
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Removes
optionsas the second parameter. The first parameter now acceptsidoroptionswhich can also have theidproperty. Internal discussion hereBREAKING CHANGE:
ApplicationCommandManager#fetchandGuildApplicationCommandManager#fetchno longer accept 2 parameters. Instead, the first parameter acceptsidoroptionswhich can now also have theidproperty.Status and versioning classification: