build: Properly add typecheck tests #10722
Merged
+410
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
previously approved these changes
Jan 21, 2025
kyranet
previously approved these changes
Jan 21, 2025
Jiralite
force-pushed
the
build/no-test-run
branch
5 times, most recently
from
49ae1a5 to
c85b3cd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
almeidx
force-pushed
the
build/no-test-run
branch
from
b3c96e4 to
6093e6e
Compare
almeidx
requested review from
vladfrangu,
didinele,
kyranet,
SpaceEEC,
almeidx,
monbrey and
almostSouji
almeidx
approved these changes
Jan 24, 2025
almeidx
force-pushed
the
build/no-test-run
branch
from
889d4c1 to
e1ba392
Compare
remove unused test scripts skip lib check rm vitest.d.ts
almeidx
force-pushed
the
build/no-test-run
branch
from
e1ba392 to
5dffaba
Compare
ckohen
approved these changes
Jan 26, 2025
didinele
approved these changes
Jan 26, 2025
Jiralite
changed the title
iCrawl
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we'd get errors about tests in core, which are supposedly from them running. Properly adding type checks to our testing now.