Exclude FileSystemTests from parallelization

[majocha]

FileSystem is a not thread-safe resource. These tests need to be excluded from parallelization.

[github-actions]

✅ No release notes required

[psfinaki]

@majocha I am afraid we might want to do something on top of this since the current execution has crashed on Linux again :/

The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred: 
Signatures.SigGenerationRoundTripTests.Generate and compile
Language.ExtensionMethodTests.Recursive toplevel named module with Extension attribute and top level let binding with Extension attribute
Language.FixedBindings.Legacy.Pin generic with unmanaged - illegal

[majocha]

@psfinaki, I will add a small section about this to TESTGUIDE later, as you suggested.
Probably CI will catch a few more test cases needing exemption from parallelism. I'll keep an eye.

[majocha]

@majocha I am afraid we might want to do something on top of this since the current execution has crashed on Linux again :/

The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred: 
Signatures.SigGenerationRoundTripTests.Generate and compile
Language.ExtensionMethodTests.Recursive toplevel named module with Extension attribute and top level let binding with Extension attribute
Language.FixedBindings.Legacy.Pin generic with unmanaged - illegal

Yeah, currently we're at

fsharp/eng/build.sh

Line 223 in 65a9f1e

args+=" -- xUnit.MaxParallelThreads=3"

and apparently CI can't handle it. It was low on memory even before, so maybe it's that?

[psfinaki]

Yeah, I remember the low memory warnings... let's see how this plays out. Thanks for taking care :)

[psfinaki]

Alrighty, so this works although the CI still reports low memory on Linux.

I've looked at a few runs, in all of them the memory gets tight during FsharpSuiteMigrated_TypeCheckTests.

Wonder if we should make them sequential to be an the safe side? We don't have to if it brings the times back again, I am just curious.

[majocha]

Alrighty, so this works although the CI still reports low memory on Linux.

I think that low memory was there even before parallel testing PR.

I've looked at a few runs, in all of them the memory gets tight during FsharpSuiteMigrated_TypeCheckTests.

I'm not sure it's that, given that basically all of them have [<FactForDESKTOP>] i.e. should not run at all on linux?

I wonder if this could be related to the Internal CLR error. (0x80131506) we've seen before. We have a minidump so maybe we should open an issue about it somewhere? Maybe in dotnet/runtime?

[github-actions]

Failed to run : https://github.com/dotnet/fsharp/actions/runs/12373283117

[psfinaki]

Right, yeah it's skipping them.

I wonder if this could be related to the Internal CLR error. (0x80131506) we've #17872 (comment). We have a minidump so maybe we should open an issue about it somewhere? Maybe in dotnet/runtime?

Worth trying, at least maybe they can investigate it a bit :)

[github-actions]

Failed to run : https://github.com/dotnet/fsharp/actions/runs/12374820478

[majocha]

Right, yeah it's skipping them.

I wonder if this could be related to the Internal CLR error. (0x80131506) we've #17872 (comment). We have a minidump so maybe we should open an issue about it somewhere? Maybe in dotnet/runtime?

Worth trying, at least maybe they can investigate it a bit :)

@psfinaki, I opened an issue for this here: dotnet/runtime#110837 with the minidump we got 3 weeks ago.
This became quite common: https://dev.azure.com/dnceng-public/public/_build/results?buildId=899623&view=logs&j=170942dc-5349-5022-2275-77744f335216&t=20776a93-33c2-52f0-ee8f-b8c9809b2e23&l=14650
maybe it'd be helpful to provide them with additional more recent dumps from above? I can download logs but I don't think I have access to dumps.

[github-actions]

Failed to run : https://github.com/dotnet/fsharp/actions/runs/12416108147

[psfinaki]

@majocha so looks like you've discovered a real issue :)
Yeah I added another one, hopefully the right thing.