Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal option–voption conversions with FSharp.Core funcs #18269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace internal option–voption conversions with FSharp.Core funcs #18269

wants to merge 1 commit into from

Conversation

brianrourkeboll
Copy link
Contributor

Description

Reprise of #17457, now that FSharp.Core 9 has shipped.

Resolves #17460.

Checklist

  • These changes are internal only, so release notes shouldn't be needed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@brianrourkeboll brianrourkeboll marked this pull request as ready for review January 25, 2025 20:44
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner January 25, 2025 20:44
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 27, 2025
@T-Gro T-Gro enabled auto-merge (squash) January 27, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: replace internal option conversion funcs with FSharp.Core ones once shipped
2 participants
@brianrourkeboll @T-Gro