-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 Drop deprecated hexa*
#5644
base: main
Are you sure you want to change the base?
💥 Drop deprecated hexa*
#5644
Conversation
**Description** <!-- Please provide a short description and potentially linked issues justifying the need for this PR --> The arbitraries `hexa` and `hexaString` have been marked for deprecation since version 3.22.0. They are now being fully dropped. If you still want to rely on something behaving this way we recommend you to use the following constructs: ```ts const items = '0123456789abcdef'; function hexa(): fc.Arbitrary<string> { return fc.integer({ min: 0, max: 15 }).map(n => items[n]); } function hexaString(constraints: fc.StringConstraints = {}): fc.Arbitrary<string> { return fc.string({ ...constraints, unit: hexa() }); } ``` <details><summary> Or even more accurate</summary> ```ts function hexa(): fc.Arbitrary<string> { return fc.integer({ min: 0, max: 15 }).map( (n) => items[n], (c) => { if (typeof c !== 'string') { throw new Error('Not a string'); } const index = items.indexOf(c); if (index === -1) { throw new Error('Unknown "char"'); } return index; }, ); } // Or shorter function hexa(): fc.Arbitrary<string> { return fc.integer({ min: 0, max: 15 }).map( (n) => items[n], (c) => items.indexOf(c), ); } ``` </details> <!-- * Your PR is fixing a bug or regression? Check for existing issues related to this bug and link them --> <!-- * Your PR is adding a new feature? Make sure there is a related issue or discussion attached to it --> <!-- You can provide any additional context to help into understanding what's this PR is attempting to solve: reproduction of a bug, code snippets... --> **Checklist** — _Don't delete this checklist and make sure you do the following before opening the PR_ - [x] The name of my PR follows [gitmoji](https://gitmoji.dev/) specification - [x] My PR references one of several related issues (if any) - [x] New features or breaking changes must come with an associated Issue or Discussion - [x] My PR does not add any new dependency without an associated Issue or Discussion - [x] My PR includes bumps details, please run `yarn bump` and flag the impacts properly - [x] My PR adds relevant tests and they would have failed without my PR (when applicable) <!-- More about contributing at https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md --> **Advanced** <!-- How to fill the advanced section is detailed below! --> - [x] Category: 💥 Breaking change - [x] Impacts: Dropped arbitraries <!-- [Category] Please use one of the categories below, it will help us into better understanding the urgency of the PR --> <!-- * ✨ Introduce new features --> <!-- * 📝 Add or update documentation --> <!-- * ✅ Add or update tests --> <!-- * 🐛 Fix a bug --> <!-- * 🏷️ Add or update types --> <!-- * ⚡️ Improve performance --> <!-- * _Other(s):_ ... --> <!-- [Impacts] Please provide a comma separated list of the potential impacts that might be introduced by this change --> <!-- * Generated values: Can your change impact any of the existing generators in terms of generated values, if so which ones? when? --> <!-- * Shrink values: Can your change impact any of the existing generators in terms of shrink values, if so which ones? when? --> <!-- * Performance: Can it require some typings changes on user side? Please give more details --> <!-- * Typings: Is there a potential performance impact? In which cases? -->
🦋 Changeset detectedLatest commit: effa0f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open in Stackblitz • @fast-check/examples @fast-check/ava
fast-check
@fast-check/expect-type
@fast-check/jest
@fast-check/poisoning
@fast-check/packaged
@fast-check/vitest
@fast-check/worker
commit: |
👋 A preview of the new documentation is available at: http://6793d64d934a5ef23060bee8--dubzzz-fast-check.netlify.app |
👋 A preview of the new documentation is available at: http://6793d7b2ed7ef085070c6845--dubzzz-fast-check.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5644 +/- ##
==========================================
- Coverage 94.81% 94.78% -0.03%
==========================================
Files 230 228 -2
Lines 9989 9979 -10
Branches 2803 2798 -5
==========================================
- Hits 9471 9459 -12
- Misses 518 520 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
The arbitraries
hexa
andhexaString
have been marked for deprecation since version 3.22.0.They are now being fully dropped.
If you still want to rely on something behaving this way we recommend you to use the following constructs:
Or even more accurate
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bump
and flag the impacts properlyAdvanced