Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Drop deprecated hexa* #5644

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

💥 Drop deprecated hexa* #5644

wants to merge 4 commits into from

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 24, 2025

Description

The arbitraries hexa and hexaString have been marked for deprecation since version 3.22.0.

They are now being fully dropped.

If you still want to rely on something behaving this way we recommend you to use the following constructs:

const items = '0123456789abcdef';
function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(n => items[n]);
}
function hexaString(constraints: fc.StringConstraints = {}): fc.Arbitrary<string> {
  return fc.string({ ...constraints, unit: hexa() });
}
Or even more accurate
function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(
    (n) => items[n],
    (c) => {
      if (typeof c !== 'string') {
        throw new Error('Not a string');
      }
      const index = items.indexOf(c);
      if (index === -1) {
        throw new Error('Unknown "char"');
      }
      return index;
    },
  );
}

// Or shorter

function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(
    (n) => items[n],
    (c) => items.indexOf(c),
  );
}

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 💥 Breaking change
  • Impacts: Dropped arbitraries

**Description**

<!-- Please provide a short description and potentially linked issues
justifying the need for this PR -->

The arbitraries `hexa` and `hexaString` have been marked for deprecation
since version 3.22.0.

They are now being fully dropped.

If you still want to rely on something behaving this way we recommend
you to use the following constructs:

```ts
const items = '0123456789abcdef';
function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(n => items[n]);
}
function hexaString(constraints: fc.StringConstraints = {}): fc.Arbitrary<string> {
  return fc.string({ ...constraints, unit: hexa() });
}
```

<details><summary>
Or even more accurate</summary>

```ts
function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(
    (n) => items[n],
    (c) => {
      if (typeof c !== 'string') {
        throw new Error('Not a string');
      }
      const index = items.indexOf(c);
      if (index === -1) {
        throw new Error('Unknown "char"');
      }
      return index;
    },
  );
}

// Or shorter

function hexa(): fc.Arbitrary<string> {
  return fc.integer({ min: 0, max: 15 }).map(
    (n) => items[n],
    (c) => items.indexOf(c),
  );
}
```
</details>

<!-- * Your PR is fixing a bug or regression? Check for existing issues
related to this bug and link them -->
<!-- * Your PR is adding a new feature? Make sure there is a related
issue or discussion attached to it -->

<!-- You can provide any additional context to help into understanding
what's this PR is attempting to solve: reproduction of a bug, code
snippets... -->

**Checklist** — _Don't delete this checklist and make sure you do the
following before opening the PR_

- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `yarn bump` and flag the
impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)

<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->

**Advanced**

<!-- How to fill the advanced section is detailed below! -->

- [x] Category: 💥 Breaking change
- [x] Impacts: Dropped arbitraries

<!-- [Category] Please use one of the categories below, it will help us
into better understanding the urgency of the PR -->
<!-- * ✨ Introduce new features -->
<!-- * 📝 Add or update documentation -->
<!-- * ✅ Add or update tests -->
<!-- * 🐛 Fix a bug -->
<!-- * 🏷️ Add or update types -->
<!-- * ⚡️ Improve performance -->
<!-- * _Other(s):_ ... -->

<!-- [Impacts] Please provide a comma separated list of the potential
impacts that might be introduced by this change -->
<!-- * Generated values: Can your change impact any of the existing
generators in terms of generated values, if so which ones? when? -->
<!-- * Shrink values: Can your change impact any of the existing
generators in terms of shrink values, if so which ones? when? -->
<!-- * Performance: Can it require some typings changes on user side?
Please give more details -->
<!-- * Typings: Is there a potential performance impact? In which cases?
-->
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: effa0f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check Major
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 24, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5644

fast-check

npm i https://pkg.pr.new/fast-check@5644

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5644

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5644

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5644

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5644

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5644

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5644

commit: effa0f3

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6793d64d934a5ef23060bee8--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6793d7b2ed7ef085070c6845--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.78%. Comparing base (8c3a9bb) to head (effa0f3).

Files with missing lines Patch % Lines
packages/fast-check/src/arbitrary/ipV6.ts 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5644      +/-   ##
==========================================
- Coverage   94.81%   94.78%   -0.03%     
==========================================
  Files         230      228       -2     
  Lines        9989     9979      -10     
  Branches     2803     2798       -5     
==========================================
- Hits         9471     9459      -12     
- Misses        518      520       +2     
Flag Coverage Δ
unit-tests 94.78% <88.23%> (-0.03%) ⬇️
unit-tests-18.x-Linux 94.78% <88.23%> (-0.03%) ⬇️
unit-tests-20.x-Linux 94.78% <88.23%> (+0.02%) ⬆️
unit-tests-22.x-Linux 94.78% <88.23%> (-0.03%) ⬇️
unit-tests-latest-Linux 94.73% <88.23%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant