Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tracing configuration to the rust side. #3668

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Move tracing configuration to the rust side. #3668

merged 2 commits into from
Jan 10, 2025
+375 −425

Conversation

stefanceriu
Copy link
Member

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3e4c021

pixlwave
pixlwave approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Took me a second to figure out what the new appTarget parameter did in the setup call, but I got there in the end 😅

ElementX/Sources/Services/BugReport/BugReportService.swift Show resolved Hide resolved
@stefanceriu stefanceriu marked this pull request as ready for review January 10, 2025 16:20
@stefanceriu stefanceriu requested a review from a team as a code owner January 10, 2025 16:20
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 10, 2025 16:20
@stefanceriu stefanceriu force-pushed the stefan/rustSideTracingConfiguration branch from e70f9a5 to 3e4c021 Compare January 10, 2025 16:20
@stefanceriu stefanceriu added the pr-misc for other changes label Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
906 1 905 0
View the full list of 1 ❄️ flaky tests 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithCaption()

Flake rate in main: 25.00% (Passed 15 times, Failed 5 times)

Stack Traces | 11.2s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit ab334e9 into develop Jan 10, 2025
10 checks passed
@stefanceriu stefanceriu deleted the stefan/rustSideTracingConfiguration branch January 10, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave