-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling for editing alias in case of different HS #3695
Better handling for editing alias in case of different HS #3695
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3695 +/- ##
===========================================
- Coverage 78.68% 78.68% -0.01%
===========================================
Files 792 792
Lines 67742 67844 +102
===========================================
+ Hits 53306 53382 +76
- Misses 14436 14462 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ElementX/Sources/Screens/EditRoomAddressScreen/EditRoomAddressScreenViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
Would be useful to update the EditRoomAddressScreenViewModelTests.testCorrectMethodsCalledOnSave
test as well now.
possible cases on how the save is handled given the various context of the existing room alias
Just added a bunch of tests with expectation for all the possible cases! |
Quality Gate passedIssues Measures |
We only update the alias if the new alias belongs to the same homeserver or one did not exist yet, otherwise we add it in the list of the alternative ones