Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for editing alias in case of different HS #3695

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 22, 2025

We only update the alias if the new alias belongs to the same homeserver or one did not exist yet, otherwise we add it in the list of the alternative ones

@Velin92 Velin92 requested a review from a team as a code owner January 22, 2025 14:41
@Velin92 Velin92 requested review from stefanceriu and ganfra and removed request for a team January 22, 2025 14:41
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 95.04132% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (48e530f) to head (751cb3e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...AddressScreen/EditRoomAddressScreenViewModel.swift 82.35% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3695      +/-   ##
===========================================
- Coverage    78.68%   78.68%   -0.01%     
===========================================
  Files          792      792              
  Lines        67742    67844     +102     
===========================================
+ Hits         53306    53382      +76     
- Misses       14436    14462      +26     
Flag Coverage Δ
unittests 70.20% <95.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍
Would be useful to update the EditRoomAddressScreenViewModelTests.testCorrectMethodsCalledOnSave test as well now.

possible cases on how the save is handled given the various context of the existing room alias
@Velin92
Copy link
Member Author

Velin92 commented Jan 22, 2025

Makes sense to me 👍 Would be useful to update the EditRoomAddressScreenViewModelTests.testCorrectMethodsCalledOnSave test as well now.

Just added a bunch of tests with expectation for all the possible cases!

@Velin92 Velin92 enabled auto-merge (squash) January 22, 2025 17:18
Copy link

@Velin92 Velin92 merged commit 3162bf7 into develop Jan 22, 2025
8 checks passed
@Velin92 Velin92 deleted the mauroromito/handle_canonical_alias_for_different_hs branch January 22, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants