Make sure the Recovery Key option is shown on the IdentityConfirmationScreen when available. #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nScreen when available. There was a race condition where 2 different states could be processed at the same time.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
The view model wasn't stored, so relying the current value publisher didn't have time to fire before deinit.
Generated by 🚫 Danger Swift against 2d88f34 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition where 2 different states could be processed at the same time:
Even though the method is
@MainActor, the fact it has anawaitmeans that if another Task is spawned when a previous one is suspended, there was no guarantee that they would resume in the same order. This PR calls the method using afor await into process the states serially.