watchdog for mongooseim #2109
watchdog for mongooseim #2109
Conversation
|
5771.1 / Erlang 19.3 / small_tests / 6cd30e2 5771.3 / Erlang 19.3 / mysql_redis / 6cd30e2 5771.2 / Erlang 19.3 / internal_mnesia / 6cd30e2 5771.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 6cd30e2 5771.4 / Erlang 19.3 / odbc_mssql_mnesia / 6cd30e2 5771.5 / Erlang 19.3 / ldap_mnesia / 6cd30e2 5771.8 / Erlang 20.0 / pgsql_mnesia / 6cd30e2 5771.9 / Erlang 21.0 / riak_mnesia / 6cd30e2 |
| @@ -714,6 +714,13 @@ | |||
|
|
|||
| {services, | |||
| [ | |||
| %% {mongoose_watchdog, [{os_mon_env, [{start_cpu_sup, true}, | |||
There was a problem hiding this comment.
I'd prefer to keep a convention to prefix services with service_
| @@ -0,0 +1,236 @@ | |||
| %%%------------------------------------------------------------------- | |||
| %%% @author denys | |||
There was a problem hiding this comment.
I think we should do either of:
- Not add this kind of comment at all. My preferred option, there's
git logto check authors, commit dates & stuff, there's a COPYING file in the repo for the license. - Actually make it useful and binding wrt copyright: use a
First Last <email@company>for@author(that's what git uses, that's the minimum info required for people outside the team), use the actual company name instead of<COMPANY>for@copyright, use the current year - 2019, and actually write something in@doc.
There was a problem hiding this comment.
i would rather want to have local readme.md file for this functionality than put it in the @doc section.
There was a problem hiding this comment.
I guess it wouldn't hurt to leave a one or two sentence long summary in the @doc section and point to more details in the README.
| %%% Created : 08. Oct 2018 16:08 | ||
| %%%------------------------------------------------------------------- | ||
| -module(mongoose_watchdog). | ||
| -author("DenysGonchar"). |
There was a problem hiding this comment.
Same as in the doc comment - First Last <email@company>.
inspiration is taken from here
processone/ejabberd@515f8b2
TODO: