-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rafthttp: Improve warn message in checkClusterCompatibilityFromHeader #19112
Conversation
Signed-off-by: adeyemi <[email protected]>
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ivanvc I stumbled on this misleading message. Please let me know if an issue should be created to update this. |
Signed-off-by: adeyemi <[email protected]>
I agree; from reading the code, it didn't fail to check the version compatibility, but there's a version mismatch. /ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 29 files with indirect coverage changes @@ Coverage Diff @@
## main #19112 +/- ##
==========================================
- Coverage 68.79% 68.78% -0.02%
==========================================
Files 420 420
Lines 35640 35640
==========================================
- Hits 24520 24515 -5
- Misses 9693 9697 +4
- Partials 1427 1428 +1 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: adeyemi <[email protected]>
/retitle rafthttp: Improve warn message in checkClusterCompatibilityFromHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aladesawe.
Just emphasizing my previous comment: #19112 (comment).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, aladesawe, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update typo in the warn message
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.