Slider large max bug #3013
Open
Slider large max bug #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slider having issues handling min - max difference larger then 1000 points (ticks/steps).
dragging slider acorss large min-max values introduces lag
Screen.Recording.2025-01-14.161204.mp4
This PR aims handle the issue for users by ensuring the slider has a maximum 1000 steps. It also logs to the user the minimum step count the user should use for their slider.
Screen.Recording.2025-01-15.110104.mp4
By introducing minimum steps, the slider value now snaps to the exact maximum when it comes within a 99% threshold, ensuring users can always reach the maximum, even if the step sizes don't align perfectly.Checklist