Added an integration test to check if the analyzer comments are present at website-copy #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see the point of this. If the comments don't end up in the other repo, how is that an issue in this repo? Having a quick glance at the website-copy repo, the actual URL seems to have changed in the meantime. It's not good to have tests that can be broken by downstream, so I'm wondering what value these tests provide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of test cases that check if the analyzer comments are present at the website-copy repo.
The check is done using the Github contents API.
While these test cases are somewhat inconvenient, since they use the Internet connection to make the HTTP requests to the API with a limited number of allowed requests, it is compensated by the fact that at the time this PR is opened there is not much traffic at this repository.