Skip to content

Commit

Permalink
cabal: turn off C++ -Wnullability-completeness warning (#488)
Browse files Browse the repository at this point in the history
Summary:
This stops the C++ compiler from spitting out a little over 18,000 lines of C++ warnings about pointer nullability, which makes the GitHub logs actually unusable.

Pull Request resolved: #488

Reviewed By: josefs

Differential Revision: D68622988

Pulled By: simonmar

fbshipit-source-id: 95f3d657fb78c149467ffdef72272e1f29f22d6a
  • Loading branch information
thoughtpolice authored and facebook-github-bot committed Jan 24, 2025
1 parent 0e9869d commit 210ed41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion glean.cabal.in
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ common fb-haskell
ghc-options: -O2

common fb-cpp
cxx-options: -std=c++17
cxx-options: -std=c++17 -Wno-nullability-completeness
if !flag(clang)
cxx-options: -fcoroutines
if arch(x86_64)
Expand Down

0 comments on commit 210ed41

Please sign in to comment.