Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify current instance assertion and add test status utility #817

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 9, 2025

Use Progress to assert the current instance and add utility to print change across test F3 nodes useful for debugging.

@masih masih marked this pull request as ready for review January 9, 2025 16:42
@masih masih requested a review from Kubuxu January 9, 2025 16:43
@masih masih force-pushed the masih/f3-test-util branch from 2abd16c to 668558a Compare January 9, 2025 17:11
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.55%. Comparing base (3507ce2) to head (31fde38).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   68.78%   68.55%   -0.23%     
==========================================
  Files          81       81              
  Lines        8307     8307              
==========================================
- Hits         5714     5695      -19     
- Misses       2106     2120      +14     
- Partials      487      492       +5     

see 4 files with indirect coverage changes

@BigLep BigLep added this to the M2: Mainnet Passive Testing milestone Jan 10, 2025
Use `Progress` to assert the current instance and add utility to print
change across test F3 nodes useful for debugging.
@masih masih force-pushed the masih/f3-test-util branch from 668558a to 31fde38 Compare January 10, 2025 16:03
@masih masih enabled auto-merge January 10, 2025 16:06
@masih masih self-assigned this Jan 10, 2025
@masih masih added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit c4b5f6a Jan 10, 2025
14 checks passed
@masih masih deleted the masih/f3-test-util branch January 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants