Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate max gas is greater than zero for strk fee settings #2796

Merged
merged 33 commits into from
Jan 14, 2025
Merged

Validate max gas is greater than zero for strk fee settings #2796

merged 33 commits into from
Jan 14, 2025

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Dec 18, 2024 •
edited
Loading

Closes #2706

Introduced changes

Validate if fee args are greater than 0

  • Change type of max_fee, max_gas and max_gas_unit_price from Option<Felt> to Option<NonZeroFelt>

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@franciszekjob franciszekjob marked this pull request as ready for review December 18, 2024 14:25
@ksew1 ksew1 mentioned this pull request Dec 18, 2024
Merged
5 tasks
@franciszekjob franciszekjob requested a review from ksew1 December 19, 2024 00:27
ksew1
ksew1 reviewed Dec 19, 2024
View reviewed changes
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
@franciszekjob franciszekjob requested a review from Draggu December 20, 2024 09:57
ksew1
ksew1 reviewed Dec 20, 2024
View reviewed changes
crates/conversions/src/felt.rs Outdated Show resolved Hide resolved
crates/conversions/src/serde/deserialize/deserialize_impl.rs Outdated Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/conversions/src/felt.rs Outdated Show resolved Hide resolved
cptartur
cptartur requested changes Dec 20, 2024
View reviewed changes
crates/sncast/src/helpers/fee.rs Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/invoke.rs Show resolved Hide resolved
crates/sncast/tests/integration/fee.rs Show resolved Hide resolved
crates/conversions/src/serde/deserialize/deserialize_impl.rs Show resolved Hide resolved
crates/conversions/src/felt.rs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ddoktorski ddoktorski removed their request for review December 20, 2024 15:30
@franciszekjob franciszekjob changed the title Validate max gas is greater than zero for in for strk fee settings Validate max gas is greater than zero for strk fee settings Jan 7, 2025
cptartur
cptartur approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, but otherwise looks good

@franciszekjob franciszekjob mentioned this pull request Jan 14, 2025
Open
@franciszekjob franciszekjob added this pull request to the merge queue Jan 14, 2025
Merged via the queue into master with commit a530f45 Jan 14, 2025
38 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/2706-validate-fee-args-greater-than-zero branch January 14, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski ddoktorski approved these changes

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

@ksew1 ksew1 Awaiting requested review from ksew1

@Draggu Draggu Awaiting requested review from Draggu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate fee args is greater than 0
6 participants
@franciszekjob @ddoktorski @cptartur @kkawula @Draggu @ksew1