Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation info of version flag #2834

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add deprecation info of version flag #2834

wants to merge 23 commits into from

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Jan 9, 2025 •
edited
Loading

Closes #2828

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula changed the title version deprecation info Add deprecation info of version flag Jan 9, 2025
@kkawula kkawula marked this pull request as ready for review January 9, 2025 11:24
cptartur
cptartur reviewed Jan 9, 2025
View reviewed changes
crates/sncast/tests/e2e/account/deploy.rs Outdated Show resolved Hide resolved
crates/sncast/src/helpers/version.rs Outdated Show resolved Hide resolved
franciszekjob
franciszekjob reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Shouldn't we update this message then? If someone uses --token we say Use '--version' instead while version will be deprecated too. I think we can just remove Use '--version' instead sentence.
  2. CI is failing 👀

Otherwise looks fine 👍

@kkawula kkawula marked this pull request as draft January 10, 2025 08:07
@kkawula kkawula marked this pull request as ready for review January 10, 2025 10:01
franciszekjob
franciszekjob approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts in changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 ksew1 left review comments

@franciszekjob franciszekjob franciszekjob approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate versions other than v3 in sncast commands that accept --version
4 participants
@kkawula @cptartur @franciszekjob @ksew1