Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serve AWS assets on CDN instead #287

Merged

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Jan 9, 2025

Checklist:

They should be hosted on https://cdn.freecodecamp.org/ since S3 is designed to store content, not serve it. By using the CDN the lesson assets can be cached near the learner, resulting in better performance.

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner January 9, 2025 12:39
@Sembauke Sembauke changed the title fix: serveable AWS assets on CDN instead fix: serve AWS assets on CDN instead Jan 9, 2025
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams enabled auto-merge (squash) January 9, 2025 14:18
@ojeytonwilliams ojeytonwilliams merged commit c1fe1fe into freeCodeCamp:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants