Remove method and modeledMethods from SaveModeledMethods message #2913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
methods
andmodeledMethods
fields fromSaveModeledMethods
in favour of includingmethodSignatures
. The extension host can use theModelingStore
to look up the methods and modelings using the method signatures.Involves adding
getMethods
andgetModeledMethods
toModelingStore
.Tested locally and seems to be saving models and updating the "unsaved" labels correctly.
Checklist
ready-for-doc-review
label there.