Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method and modeledMethods from SaveModeledMethods message #2913

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

robertbrignull
Copy link
Contributor

Removes the methods and modeledMethods fields from SaveModeledMethods in favour of including methodSignatures. The extension host can use the ModelingStore to look up the methods and modelings using the method signatures.

Involves adding getMethods and getModeledMethods to ModelingStore.

Tested locally and seems to be saving models and updating the "unsaved" labels correctly.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners October 5, 2023 16:01
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robertbrignull robertbrignull merged commit c620939 into main Oct 9, 2023
@robertbrignull robertbrignull deleted the robertbrignull/SaveModeledMethods branch October 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants