-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additionalArgs
option to launch.json
#2922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be gated by a check on canary mode. I don't feel too strongly about this since it's internal and undocumented anyway.
In terms of naming, something that evokes that it is internal and for running queries might be nicer. Eg- additionalRunQueryArgsInternal
, or even internalrunQueryArgs
.
query: quickEvalQueryPath, | ||
additionalArgs: { | ||
// Overrides the value passed to the query server | ||
queryPath: simpleQueryPath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh...interesting. This will allow you to override any args set by the extension. Could be dangerous, but then again it's an internal, undocumented feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. There are a few sharp edges.
I like
I'd like to see the property in autocomplete. If we expect more than a handful of internal users to ever use this property, it should be as discoverable as possible. It seems to me that it's a small price to pay if a handful of external users discover it too and find it confusing. This property should only confuse someone who (1) ventures into |
@jbj I like both of your suggestions, especially in combination. I've renamed the property to |
This PR adds a new
additionalArgs
property to the QL debug configuration specified inlaunch.json
. The property accepts a JSON object and passes all of the properties of that JSON object through to therunQuery
method of the query server, without validation or interpretation. This makes it easier to prototype new query server features without having to make updates to the VS Code extension. The new property is not declared inpackage.json
, to avoid encouraging accidental use.Bikeshed Request: What's a better name for this property? Since it isn't in
package.json
, it won't show up in autocomplete forlaunch.json
, so it should be something that internal users can remember.Implementation notes:
Most of the code changes are just plumbing the new property all the way through to the query server.