-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Increase IDE awareness during onboarding #9432
Conversation
d837cf9
to
b42fa95
Compare
e5d2989
to
9ff58b6
Compare
@@ -55,52 +51,6 @@ export default function Preferences() { | |||
}; | |||
migrationIDESettings(); | |||
|
|||
const updateUserIDEInfo = async (selectedIde: string, useLatestVersion: boolean) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've extracted the logic to present & save the IDE preference from the Preferences
page into a dedicated component <SelectIDE>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateUserIDEInfo
was also moved to its own file, to allow reusability
9ff58b6
to
c6ccddc
Compare
c6ccddc
to
74c07d5
Compare
/werft run with-vm=true 👍 started the job as gitpod-build-af-ide-discovery-6707.12 |
74c07d5
to
ed8a514
Compare
c4be658
to
5576b3f
Compare
cc0d6d2
to
2ae002d
Compare
Maybe we can also track here about how many people visit this IDE options page in dashboard etc |
3dd2638
to
e4477ac
Compare
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-af-ide-discovery-6707.28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andreafalzetti!
I tried to test this changes, but was not able to trigger the modal to be shown.
'Verified several times and re-created accounts on the preview env, and also deleted cookies in between.
'Trying to debug I could see that User.isOnboardingUser(user!) === true
in Workspaces.tsx initially and the modal's frame is about to render, but the next thing this is updated and some default IDE settings are set. Is that expected? I suppose this is not intended.
Same here! Cc @AlexTugarev |
956e3ab
to
c8994af
Compare
Co-authored-by: mustard <[email protected]> Co-authored-by: andreafalzetti <[email protected]>
c8994af
to
faef3f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I tested the new onboarding modal several times and it worked as advertised.
return !hasPreferredIde(user); | ||
} | ||
|
||
export function migrationIDESettings(user: User) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mustard-mh @andreafalzetti Why did we pull it to protocol from dashboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akosyakov This? #9432 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reads like you agree to put it in dashboard though, not in protocol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we agreed to put it in protocol
Description
An experiment to try to increase the awareness of other IDEs besides VS Code.
Every selection from user will change User setting immediately
The approach used:
<SelectIDE>
<SelectIDEModal>
Extracted the utilupdateUserIDEInfo
from<SelectIDE>
to its own file<SelectIDE>
in both the settings page and in SelectIDEModal<SelectIDEModal>
will appear in the workspaces page, if the user isOnboardingUserRelated Issue(s)
Fixes #9433
Relates to #6707
How to test
The first thing to test is that workspaces started without this new preference, will default to VS Code browser. If you want to only test the onboarding flow, skip all
[optional]
steps below.[optional]
Before selecting an IDE, try creating a workspace appending the repo to the preview env URL. This will make sure that users who skip this selection, can still launch workspaces withcode
as default IDE.[optional]
Once the workspace starts, verify that VS Code Browser is the default IDE[optional]
Stop the workspacegp stop
and go back to the dashboard and delete your workspace[optional]
Go back to the workspaces pageTest Cases
Every selection from user will change User setting immediately
continue
orX
, DB go withcode latest:false
use latest
and click continue orX
, DB go withcode latest:true
FYI: Check and reset your ide option
Release Notes
Screenshots