Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmux and neovim chunks and use them in the full image #825

Closed
wants to merge 6 commits into from

Conversation

andrew-farries
Copy link
Contributor

Description

Add neovim and tmux chunks and include them in the full workspace image.

We've recently done some great work to make Gitpod easier to use for users with CLI based workflows by making workspaces simpler to access via SSH and supporting dotfiles repos to allow customisation of the CLI environment.
As this is a use-case we want to support, we should also have tools available in the default workspace image that support such a workflow.

This PR adds tmux and neovim to the full image. tmux is the terminal multiplexer, and neovim is a modern fork of vim with full LSP support that serves as an alternative to full-blown IDEs for users who prefer the CLI.

Related Issue(s)

How to test

Dazzle tests added for the two new tools.

Release Notes

Add `tmux` and `neovim` tools to the `full` workspace image

Documentation

None required AFAIK.

@andrew-farries andrew-farries requested a review from a team May 1, 2022 21:04
@gitpod-io
Copy link

gitpod-io bot commented May 1, 2022

@utam0k
Copy link
Contributor

utam0k commented May 1, 2022

Hi, @andrew-farries. Thanks for your PR. What about preparing an image for cli instead of installing it in full image? I think most users use vscode. In that case, I feel that these two alternative functions are provided in vscode.

@utam0k
Copy link
Contributor

utam0k commented May 1, 2022

@gitpod-io/engineering-workspace I'd like to see what others have to say.

@csweichel
Copy link
Collaborator

Hi, @andrew-farries. Thanks for your PR. What about preparing an image for cli instead of installing it in full image? I think most users use vscode. In that case, I feel that these two alternative functions are provided in vscode.

Totally follow that sentiment.
From a user-experience perspective that would not be great though. The workspace image is set on a project level, using SSH is a personal preference.

The right way to go would be to introduce an "SSH desktop IDE image" (cc @loujaybee @akosyakov). For now though I reckon we could merge this change.

@akosyakov
Copy link
Member

akosyakov commented May 2, 2022

The right way to go would be to introduce an "SSH desktop IDE image" (cc @loujaybee @akosyakov). For now though I reckon we could merge this change.

👍

@loujaybee We track it right now in gitpod-io/gitpod#9323 but for VIM, so maybe we rather turn it into more generic CLI editor. I also think it can be a quick win, having something like vim, tmux, neovim in it will be enough.

@akosyakov
Copy link
Member

akosyakov commented May 2, 2022

Actually @andrew-farries you can go ahead and give it a try by opening a PR:

After that you can ping us to update the start screen a bit to provide you with copy/paste CLI command to start.

@andrew-farries
Copy link
Contributor Author

@akosyakov Thanks; I'll attempt a PR to add a new IDE image and close this.

@andrew-farries andrew-farries deleted the af/add-tmux-neovim-to-full branch May 3, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants