-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET: Downgrade Microsoft.CodeAnalysis.CSharp to 4.8.0 for compat with SDK 8.0.1xy #100506
.NET: Downgrade Microsoft.CodeAnalysis.CSharp to 4.8.0 for compat with SDK 8.0.1xy #100506
Conversation
1d8ed01
to
0c00dd6
Compare
e1f3a4b
to
a02ae56
Compare
1d02b04
to
21ca022
Compare
Finally got the CI config to work. I couldn't make The CI run for 21ca022 properly fails, confirming #100502: https://github.com/godotengine/godot/actions/runs/12375025460/job/34538922837?pr=100506
|
And https://github.com/godotengine/godot/actions/runs/12375157412/job/34539363154 confirms that 5232760 solves the issue. I'll squash the two commits now so this is ready to merge. |
…h SDK 8.0.1xy And for CI, set up .NET SDK 8.0.100 explicitly to test our min supported version.
5232760
to
4047e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry for missing this in the original PR.
And for CI, set up .NET SDK 8.0.100 explicitly to test our min supported version.
Should fail now due to #100502, and we can use it to validate the upcoming fix.master
branch #100502.