Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worfklows: update upload-artifacts version #1372

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jan 9, 2025

v3 of upload-artifacts will soon error out, so we need to migrate to v4.

I tested that it works by temporarily removing the if: failed() conditional and verifying that it uploaded artifacts.

v3 of `upload-artifacts` will soon error out, so we need to migrate to v4.
@jordigh jordigh force-pushed the jordigh/upload-artifacts branch 2 times, most recently from 1a8ca76 to 9907bb3 Compare January 9, 2025 01:23
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jordigh

@jordigh jordigh merged commit 7ea10de into main Jan 10, 2025
12 checks passed
@jordigh jordigh deleted the jordigh/upload-artifacts branch January 10, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants