Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin diffusers and pass onnx exporters tests #2153

Merged
merged 20 commits into from
Jan 13, 2025
Merged

Unpin diffusers and pass onnx exporters tests #2153

merged 20 commits into from
Jan 13, 2025

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Jan 9, 2025

What does this PR do?

There are also problems with modernbert making the CI red because it's still released in transformers.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil IlyasMoutawwakil changed the title Unpin diffusers Unpin diffusers and pass onnx exporters tests Jan 10, 2025
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @IlyasMoutawwakil

@echarlaix echarlaix merged commit c46de05 into main Jan 13, 2025
60 checks passed
@echarlaix echarlaix deleted the unpin-diffusers branch January 13, 2025 09:18
@xenova
Copy link
Contributor

xenova commented Jan 13, 2025

Thanks @IlyasMoutawwakil 👍 For modernbert, is this something we can fix with

MIN_TRANSFORMERS_VERSION = version.parse("4.48.0")

?

@IlyasMoutawwakil
Copy link
Member Author

oh yes apparently we can thanks to
https://github.com/huggingface/optimum/blob/c46de055049acc550eca1ff96414b2aba3a95dee/tests/exporters/onnx/test_onnx_export.py#L212-L216C
thanks for the catch, fixing it in a second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants