Regenerate cython files #1675
Merged
Regenerate cython files #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these need to be executable.
After re-generating core.cpp and graphics.cpp with cython 0.29.37, they don't cause build errors with Python 3.12 anymore. Fixes: hzeller#1671
|
Seeing this, I think I'd be in favor if we switch to a mode where the generated cython files are not checked in, but part of the users' build. Merging this now, but I think it would probably a better experience as stale generated code that caused the issue in the first place is not there to begin with. Would you like to rework the Python binding for this ? (I suspect it mostly involves deleting the generated files and updating the Makefile and README. (I don't use Python myself, so I would've never noticed) Anyway, merging this for now, but I think the above suggestion might be a good next step. |
|
I've put that in #1679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1671