Fix Raspberry Pi model detection on mainline Linux #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
reviewed
Jul 10, 2024
|
Looks good in general, but I don't think it does what you think it does. |
neuschaefer
commented
Jul 10, 2024
The next commit will introduce another method of determining the revision, so this commit moves the code for the /proc/cpuinfo method out of the way. While at it, also update the documentation link.
Mainline Linux does not expose the Raspberry Pi revision codes[1] in /proc/cpuinfo, and this isn't likely to change[2]. To work around this, try to retrieve the revision from the devicetree. [1]: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#raspberry-pi-revision-codes [2]: https://lore.kernel.org/lkml/[email protected]/
|
I think the logic is sound now, and I've checked that the revision is read correctly. |
hzeller
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please do not squash)