fix(server): no exif metadata in the deduplication utility #15585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
reviewed
Jan 24, 2025
Closed
3 tasks
Closed
3 tasks
alextran1502
approved these changes
Jan 24, 2025
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
…p#15585) add exif to `getDuplicates`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query didn't include exif metadata, which is problematic as it affects which assets the utility auto-selects for de-duplication.
No e2e test for this as there is no test suite for duplicates, the process of marking an asset as duplicate is closed off from the API, and we don't have machine learning enabled.