Merge pull request #1 from issue-ops/options

Avoid adding options without defaults
issue-ops · Sep 26, 2023 · 8e6ecdd · 8e6ecdd
2 parents b668877 + ecb6281
commit 8e6ecdd
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 14 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "releaser",
   "description": "Handle releases for GitHub repositories",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "author": "Nick Alteen <[email protected]>",
   "homepage": "https://github.com/issue-ops/releaser#readme",
   "repository": {

diff --git a/src/main.ts b/src/main.ts
@@ -38,18 +38,23 @@ export async function run(): Promise<void> {
   const github: Octokit = new Octokit({ auth: process.env.GITHUB_TOKEN })
 
   try {
-    // Create the release
-    const response = await github.rest.repos.createRelease({
+    // Create the API options
+    const options: any = {
       owner,
       repo,
       tag_name: tag,
-      target_commitish: target === '' ? undefined : target,
       name,
-      body: notes === '' ? undefined : notes,
       draft,
       prerelease,
       generate_release_notes: generateReleaseNotes
-    })
+    }
+
+    // Only add these options if they were provided
+    if (target !== '') options.target_commitish = target
+    if (notes !== '') options.body = notes
+
+    // Create the release
+    const response = await github.rest.repos.createRelease(options)
 
     core.debug(`Response: ${JSON.stringify(response, null, 2)}`)