Add Django 5.0 and Python 3.12 to test matrix #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrdcm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 98.95% 98.65% -0.30%
==========================================
Files 16 16
Lines 671 671
Branches 67 66 -1
==========================================
- Hits 664 662 -2
- Misses 4 5 +1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. |
aleksihakli
requested changes
May 7, 2024
|
Yeah, let's bake a release after this is merged 👍 |
Awesome! Fixed the one thing you mentioned. I suppose I could merge it but probably best you do since it's my PR :) I'm also not familiar with how to get a release of this out, are there instructions? Or if you're able to just do it, that works too and thank you! |
aleksihakli
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #201 is required for Python 3.12 so wanted to add testing to cover that, and adding Django 5.0 support at the same time.
Should probably remove support for unsupported Django and Python versions, but that might require a breaking change version bump. Hoping we can get a release out soon that has the #201 change in it, and then remove support?