Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a language selection option on index.html #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gyuhyeon
Copy link

simply adds a select field to pass response in the form.

@jjangsangy
Copy link
Owner

Good stuff, so here are the features that I would like to get implemented before merging this PR.

Requirements

  • Error page when user submits input that doesn't match the page content.
  • Cleanup the styling on the search bar.
    • You can decide how much you want to consider this. If you're confident language detection is possible, it'll just go back to 2 inputs.

Optional Features

  • Implement Language Detection
  • Figure out what fidelity you can do language detection. Are there other simpler options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants