Skip to content

Commit

Permalink
HOTFIX - Wasn't checking against arrows=false option
Browse files Browse the repository at this point in the history 
Fixes #1524
Fixes #1528
  • Loading branch information
@simeydotme
simeydotme committed Jul 13, 2015
1 parent bdcc639 commit 4f8adff
Showing 1 changed file with 19 additions and 15 deletions.
34 changes: 19 additions & 15 deletions slick/slick.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -827,28 +827,32 @@
_.$dots.remove();
}

if ( _.$prevArrow.length ) {
if ( _.options.arrows === true ) {

_.$prevArrow
.removeClass('slick-disabled slick-arrow slick-hidden')
.removeAttr('aria-hidden aria-disabled tabindex')
.css("display","");
if ( _.$prevArrow && _.$prevArrow.length ) {

if ( _.htmlExpr.test( _.options.prevArrow )) {
_.$prevArrow.remove();
_.$prevArrow
.removeClass('slick-disabled slick-arrow slick-hidden')
.removeAttr('aria-hidden aria-disabled tabindex')
.css("display","");

if ( _.htmlExpr.test( _.options.prevArrow )) {
_.$prevArrow.remove();
}
}
}

if ( _.$nextArrow.length ) {
if ( _.$nextArrow && _.$nextArrow.length ) {

_.$nextArrow
.removeClass('slick-disabled slick-arrow slick-hidden')
.removeAttr('aria-hidden aria-disabled tabindex')
.css("display","");
_.$nextArrow
.removeClass('slick-disabled slick-arrow slick-hidden')
.removeAttr('aria-hidden aria-disabled tabindex')
.css("display","");

if ( _.htmlExpr.test( _.options.nextArrow )) {
_.$nextArrow.remove();
if ( _.htmlExpr.test( _.options.nextArrow )) {
_.$nextArrow.remove();
}
}

}

if (_.$slides) {
Expand Down

6 comments on commit 4f8adff

@adriantoine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simeydotme is it gonna be released to the bower package soon?

@simeydotme
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @adriantoine .. @kenwheeler is the only one who knows how that build script magic works, haha. Otherwise I would have patched it right away. xx

@adriantoine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok no problem @simeydotme!

@kenwheeler
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simeydotme soon gentlemen. been swamped at my FT

@simeydotme
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Problem, @kenwheeler ! :)
Sorry dude; I was getting a few emails/messages about it so redirecting them back your way :P -- although it's totally my fault.

https://github.com/simeydotme/slick/blob/gulp-on-this-%F0%9F%8D%BA/gulpfile.js
Look over this once more when u get a second... I just merged master trunk back in to the branch and commented the gulpfile :)

@JackvdKlooster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably forgot to minify the js file, or haven't you commit the .min.js file yet?

Please sign in to comment.